fuhouyin/spring-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Polish OpenTelemetryResourceAttributesTests

Browse Source 
See gh-44636

Signed-off-by: Dmytro Nosan <dimanosan@gmail.com>
This commit is contained in:
Dmytro Nosan 2025-03-06 23:21:17 +02:00 committed by Stéphane Nicoll
parent 6f464e71da
commit b3f90337ec
1 changed files with 15 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/opentelemetry/OpenTelemetryResourceAttributesTests.java
View File

@ -18,13 +18,11 @@ package org.springframework.boot.actuate.autoconfigure.opentelemetry;
import java.util.LinkedHashMap; import java.util.LinkedHashMap;
import java.util.Map; import java.util.Map;
import java.util.Random;
import java.util.function.Function; import java.util.function.Function;
import java.util.stream.Stream; import java.util.stream.IntStream;
import io.opentelemetry.api.internal.PercentEscaper; import io.opentelemetry.api.internal.PercentEscaper;
import org.assertj.core.api.InstanceOfAssertFactories; import org.assertj.core.api.InstanceOfAssertFactories;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.springframework.mock.env.MockEnvironment; import org.springframework.mock.env.MockEnvironment;
@ -39,23 +37,12 @@ import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException
*/ */
class OpenTelemetryResourceAttributesTests { class OpenTelemetryResourceAttributesTests {
private static Random random;
private static final PercentEscaper escaper = PercentEscaper.create();
private final MockEnvironment environment = new MockEnvironment(); private final MockEnvironment environment = new MockEnvironment();
private final Map<String, String> environmentVariables = new LinkedHashMap<>(); private final Map<String, String> environmentVariables = new LinkedHashMap<>();
private final Map<String, String> resourceAttributes = new LinkedHashMap<>(); private final Map<String, String> resourceAttributes = new LinkedHashMap<>();
@BeforeAll
static void beforeAll() {
long seed = new Random().nextLong();
System.out.println(OpenTelemetryResourceAttributesTests.class.getSimpleName() + " seed: " + seed);
random = new Random(seed);
}
@Test @Test
void otelServiceNameShouldTakePrecedenceOverOtelResourceAttributes() { void otelServiceNameShouldTakePrecedenceOverOtelResourceAttributes() {
this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "service.name=ignored"); this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "service.name=ignored");
@ -73,13 +60,13 @@ class OpenTelemetryResourceAttributesTests {
@Test @Test
void otelResourceAttributes() { void otelResourceAttributes() {
this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES",
", ,,key1=value1,key2= value2, key3=value3,key4=,=value5,key6,=,key7=spring+boot,key8=ś"); ", ,,key1=value1,key2= value2, key3=value3,key4=,=value5,key6,=,key7=%20spring+boot%20,key8=ś");
assertThat(getAttributes()).hasSize(7) assertThat(getAttributes()).hasSize(7)
.containsEntry("key1", "value1") .containsEntry("key1", "value1")
.containsEntry("key2", "value2") .containsEntry("key2", "value2")
.containsEntry("key3", "value3") .containsEntry("key3", "value3")
.containsEntry("key4", "") .containsEntry("key4", "")
.containsEntry("key7", "spring+boot") .containsEntry("key7", " spring+boot ")
.containsEntry("key8", "ś") .containsEntry("key8", "ś")
.containsEntry("service.name", "unknown_service"); .containsEntry("service.name", "unknown_service");
} }
@ -120,12 +107,14 @@ class OpenTelemetryResourceAttributesTests {
@Test @Test
void otelResourceAttributeValuesShouldBePercentDecoded() { void otelResourceAttributeValuesShouldBePercentDecoded() {
Stream.generate(this::generateRandomString).limit(10000).forEach((value) -> { PercentEscaper escaper = PercentEscaper.create();
this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "key=" + escaper.escape(value)); String value = IntStream.range(32, 127)
assertThat(getAttributes()).hasSize(2) .collect(StringBuilder::new, StringBuilder::appendCodePoint, StringBuilder::append)
.containsEntry("service.name", "unknown_service") .toString();
.containsEntry("key", value); this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "key=" + escaper.escape(value));
}); assertThat(getAttributes()).hasSize(2)
.containsEntry("service.name", "unknown_service")
.containsEntry("key", value);
} }
@Test @Test
@ -206,10 +195,10 @@ class OpenTelemetryResourceAttributesTests {
@Test @Test
void resourceAttributesShouldTakePrecedenceOverApplicationGroupNameForPopulatingServiceNamespace() { void resourceAttributesShouldTakePrecedenceOverApplicationGroupNameForPopulatingServiceNamespace() {
this.resourceAttributes.put("service.namespace", "spring-boot-app"); this.resourceAttributes.put("service.namespace", "spring-boot-app");
this.environment.setProperty("spring.application.group", "overriden"); this.environment.setProperty("spring.application.group", "overridden");
assertThat(getAttributes()).hasSize(3) assertThat(getAttributes()).hasSize(3)
.containsEntry("service.name", "unknown_service") .containsEntry("service.name", "unknown_service")
.containsEntry("service.group", "overriden") .containsEntry("service.group", "overridden")
.containsEntry("service.namespace", "spring-boot-app"); .containsEntry("service.namespace", "spring-boot-app");
} }
@ -226,9 +215,9 @@ class OpenTelemetryResourceAttributesTests {
@Test @Test
void otelResourceAttributesShouldTakePrecedenceOverSpringApplicationGroupNameForServiceNamespace() { void otelResourceAttributesShouldTakePrecedenceOverSpringApplicationGroupNameForServiceNamespace() {
this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "service.namespace=spring-boot"); this.environmentVariables.put("OTEL_RESOURCE_ATTRIBUTES", "service.namespace=spring-boot");
this.environment.setProperty("spring.application.group", "overriden"); this.environment.setProperty("spring.application.group", "overridden");
assertThat(getAttributes()).hasSize(3) assertThat(getAttributes()).hasSize(3)
.containsEntry("service.group", "overriden") .containsEntry("service.group", "overridden")
.containsEntry("service.namespace", "spring-boot"); .containsEntry("service.namespace", "spring-boot");
} }
@ -250,11 +239,4 @@ class OpenTelemetryResourceAttributesTests {
return attributes; return attributes;
} }
private String generateRandomString() {
return random.ints(32, 127)
.limit(64)
.collect(StringBuilder::new, StringBuilder::appendCodePoint, StringBuilder::append)
.toString();
}
} }