Andy Wilkinson
b3abd25e22
Merge branch '2.1.x'
2019-02-05 11:11:07 +00:00
Andy Wilkinson
8a7958ef55
Do not use reflection to fall back to JDKs jar URLStreamHandler
...
Closes gh-15844
2019-02-05 10:59:32 +00:00
Stephane Nicoll
6baa6b291e
Polish contribution
...
Closes gh-15695
2019-01-14 08:11:20 -05:00
Johnny Lim
af3ed9ff9f
Polish
...
See gh-15695
2019-01-14 08:09:32 -05:00
igor-suhorukov
b370b1f03a
Replace indexOf() with a call to the contains()
...
See gh-15559
2018-12-24 09:52:15 +01:00
Stephane Nicoll
c948bdd14d
Merge branch '2.1.x'
2018-12-20 17:59:46 +01:00
Stephane Nicoll
51d3626c3b
Merge branch '2.0.x' into 2.1.x
2018-12-20 17:59:33 +01:00
dreis2211
27e89bbb8a
Optimize StringSequence
...
Closes gh-15473
2018-12-20 17:55:30 +01:00
Stephane Nicoll
317c4c2c38
Merge branch '2.1.x'
2018-12-17 18:26:56 +01:00
Stephane Nicoll
7dbe70dc61
Merge branch '2.0.x' into 2.1.x
2018-12-17 18:26:36 +01:00
Stephane Nicoll
c0b07a9429
Polish "Fix StringSequence.equals() for different lengths"
...
Closes gh-15465
2018-12-17 18:24:08 +01:00
dreis2211
2a0680c2ba
Fix StringSequence.equals() for different lengths
...
See gh-15465
2018-12-17 18:20:09 +01:00
Andy Wilkinson
bbf0932f0f
Exclude jcl-over-slf4j in favour of spring-jcl
...
Closes gh-15392
2018-12-07 15:37:24 +00:00
Stephane Nicoll
ef40241bf6
Merge branch '2.0.x' into 2.1.x
2018-12-05 15:56:04 +01:00
dreis2211
d864b427eb
Remove unused ByteArrayStartsWith matcher
...
Closes gh-15386
2018-12-05 15:52:42 +01:00
Andy Wilkinson
3fac0f0360
Polish multi-release jar support to avoid possible StackOverflowError
...
See gh-12523
2018-11-20 17:26:28 +00:00
Andy Wilkinson
56eebc9385
Update fat jar loader to support multi-release jar files
...
Closes gh-12523
2018-11-20 15:22:30 +00:00
Phillip Webb
f3fa20b2d1
Polish
2018-10-29 14:25:45 -07:00
dreis2211
e68b9e8322
Remove unnecessary parameters for String.substring
...
Closes gh-14661
2018-10-03 09:34:56 +02:00
Phillip Webb
d76bba5e6f
Migrate from ExpectedException rule to AssertJ
...
Replace ExpectedException JUnit rules with AssertJ exception
assertions.
Closes gh-14336
2018-10-02 10:55:28 -07:00
Phillip Webb
11b1318cad
Reduce GC pressure in JAR handler
...
Update the JAR `Hander` so that URL `startsWith` checks produce less
garbage. Comparisons are now performed first on the `path` rather than
the full `toString`. URL `toString` operations produce quite a lot of
garbage since a `StringBuilder` is always used.
In addition, we now also cache the JarFile URL toString to save repeated
calculation.
Closes gh-14561
2018-09-20 22:33:19 -07:00
Phillip Webb
2e2f91d4a0
Merge branch '1.5.x' into 2.0.x
2018-08-30 15:59:02 -07:00
Andy Wilkinson
29e38f4af8
Merge branch '1.5.x' into 2.0.x
2018-08-13 11:35:46 +01:00
Stephane Nicoll
21691f0b20
Merge branch '1.5.x' into 2.0.x
2018-08-08 14:46:55 +02:00
Phillip Webb
0ec22c8bf9
Polish copyright date on changed files
2018-07-29 09:29:29 +01:00
Phillip Webb
aeb885192e
Polish ternary expressions
2018-07-29 09:24:46 +01:00
Phillip Webb
63b609827e
Fix checkstyle method order issues
...
Fix checkstyle issues with method ordering following the
spring-javaformat upgrade.
See gh-13932
2018-07-28 01:11:53 +01:00
Phillip Webb
e6a68b39a3
Fix checkstyle javadoc issues
...
Fix checkstyle issues in javadoc following the spring-javaformat
upgrade.
See gh-13932
2018-07-28 01:11:52 +01:00
Phillip Webb
7fc455654a
Fix checkstyle ternary issues
...
Fix checkstyle issues with ternary expressions following the
spring-javaformat upgrade.
See gh-13932
2018-07-28 01:11:52 +01:00
Johnny Lim
6b0ce46491
Polish
...
Closes gh-13320
2018-06-01 09:22:20 +02:00
Phillip Webb
3751968ecd
Add missing ExpectedException rule
...
Add ExpectedException rule which was missed from the 1.5.x merge.
2018-05-30 22:52:25 -07:00
Phillip Webb
bdd541b2cc
Merge branch '1.5.x' into 2.0.x
2018-05-30 20:29:03 -07:00
Phillip Webb
5ae061f491
Merge branch '1.5.x' into 2.0.x
2018-05-30 20:27:19 -07:00
Johnny Lim
3dd2f5bb05
Polish
...
See gh-13148
2018-05-14 08:19:10 +02:00
Johnny Lim
75e591e76e
Polish
...
Closes gh-13130
2018-05-11 10:00:15 +02:00
Phillip Webb
5b3cb8a698
Update copyright header year for changed files
2018-05-04 15:59:26 -07:00
Phillip Webb
6e09e497f2
Formatting
2018-05-04 12:06:19 -07:00
Phillip Webb
41efea51a7
Polish ternary expressions
...
Consistently format ternary expressions and always favor `!=` as the
the check.
2018-05-03 22:43:12 -07:00
Phillip Webb
e125085993
Merge branch '1.5.x' into 2.0.x
2018-05-03 12:43:50 -07:00
Madhura Bhave
aad279208e
Throw exception if RandomAccessData tries to read beyond EOF
...
Fixes gh-12986
2018-05-01 16:35:43 -07:00
Johnny Lim
a723ac95a9
Polish
...
Closes gh-12999
2018-04-30 16:44:46 +02:00
Andy Wilkinson
f335ec00bf
Polish
2018-04-05 09:31:17 +01:00
Phillip Webb
696aedaef8
Merge branch '1.5.x'
2018-04-04 14:51:16 -07:00
Phillip Webb
9a64d3bf3f
Fix AsciiBytes unicode decoding
...
Fix the decoding logic in the AsciiBytes `hashCode` and `matches` to
correctly deal with multi-byte encodings.
Fixes gh-12504
2018-03-29 14:00:13 -07:00
Phillip Webb
79ad03b584
Merge branch '1.5.x'
2018-03-16 15:06:08 -07:00
Andy Wilkinson
36ea387a67
Close RandomAccessDataFile when direct JarFile is closed
...
Previously, the underlying RandomAccessDataFile was not closed when
the JarFile that was using it was closed. This causes a problem on
Windows as the open file handle prevents the file from being deleted.
This commit updates JarFile to close the underlying
RandomAccessDataFile when it is closed and has a JarFileType of
DIRECT.
Previously, when accessing the manifest of a jar file that maps to a
nested directory (BOOT-INF/classes) a new JarFile was created from the
root jar file, the manifest was retrieved, and the new JarFile was
closed. This could lead to the underlying RandomAccessDataFile being
closed while it was still in use.
This commit improves JarFile to retrieve the manifest from the
existing outer JarFile, thereby avoiding the need to create and close
a new JarFile.
Unfortunately, PropertiesLauncher creates a number of scenarios where
a JarFile with a type of direct is closed while it’s still being used.
To accommodate this behaviour, RandomAccessDataFile has been updated
so that it can re-open the underlying RandomAccessFile if it is used
after it has been closed.
Closes gh-12296
2018-03-16 15:58:50 +00:00
Andy Wilkinson
f918e0eb6a
Merge branch '1.5.x'
2018-03-05 11:55:18 +00:00
Phillip Webb
7bc535e4fa
Polish
2018-02-28 10:59:26 -08:00
Stephane Nicoll
4180762d6d
Polish contribution
...
Closes gh-12236
2018-02-28 09:01:59 +01:00
igor-suhorukov
56cbc65e7b
Polish
...
See gh-12236
2018-02-28 08:58:46 +01:00